I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-fixNotFoundFlashOnDeleteExpense
git checkout -b claude-fixNotFoundFlashOnDeleteExpense upstream/claude-fixNotFoundFlashOnDeleteExpense
git push -u origin claude-fixNotFoundFlashOnDeleteExpense

Then you can close this PR and open a new one from your fork.

@MelvinBot The issue is not fixed. While keeping the updates seems reasonable to me, the root cause appears to be a timing issue.

This only occurs on slower devices, where it takes some time for the RHP/Details page to close after the report is deleted. During that transition, the “Not Found” page becomes briefly visible while the RHP is closing.

Thanks for the feedback Krishna2323 — you're right that this is a timing issue. After investigating further, the fix in this PR addresses one layer of the problem (when the deleteTransactionNavigateBackUrl guard is cleared on the underlying ReportScreen), but the flash on slower devices comes from a second layer: the RHP page itself.

Root Cause

The withReportOrNotFound HOC wrapping ReportDetailsPage has a guard at withReportOrNotFound.tsx:97-101:

if (shouldShowNotFoundPage && contentShown.current && !isFocused) {
    return null; // prevents NotFound during close animation
}

This guard only returns null when !isFocused. On slow devices, there's a race condition:

1. Delete is confirmed → navigation dispatch + deleteTransaction() run in the same requestAnimationFrame callback
2. RHP starts its 300ms close animation
3. Onyx updates propagate: report data empties → shouldShowNotFoundPage = true
4. But isFocused is still true for the RHP page (blur event hasn't propagated yet)
5. The guard doesn't fire → HOC renders <NotFoundPage /> inside the still-visible, animating-out RHP panel → flash
6. Then isFocused flips to false → guard returns null → but flash already happened

Precedent in the Codebase

This exact pattern is already handled for transaction duplicate reviews in RightModalNavigator.tsx:130-135:

// Delay clearing review duplicate data till the RHP is completely closed
// to avoid not found showing briefly in confirmation page when RHP is closing
InteractionManager.runAfterInteractions(() => {
    abandonReviewDuplicateTransactions();
});

Suggested Fix

The deleteTransaction() call in ReportDetailsPage.tsx:1013-1016 should be deferred until after the RHP close animation completes, similar to the duplicate review pattern:

Navigation.setNavigationActionToMicrotaskQueue(() => {
    navigateToTargetUrl();
    // Delay deletion until RHP close animation finishes
    InteractionManager.runAfterInteractions(() => {
        deleteTransaction();
    });
});

This ensures the report data stays intact while the RHP is still visible and animating closed. The condition fix in this PR (clearing the guard when !isFocused) is still correct and useful for ReportScreen, but the RHP-level flash needs this additional timing fix.

Want me to update this PR with the InteractionManager approach?

Want me to update this PR with the InteractionManager approach?

@MelvinBot yes please.

Updated the PR with the InteractionManager fix. Here's a summary of both changes now in this PR:

1. DeleteTransactionNavigateBackHandler.tsx (existing commit) — Flips the isFocused condition so the deleteTransactionNavigateBackUrl guard is cleared only after navigating away from ReportScreen, not while it's still focused. This prevents the underlying ReportScreen from showing "Not Found".

2. ReportDetailsPage.tsx (new commit) — Wraps deleteTransaction() in InteractionManager.runAfterInteractions() so the Onyx data isn't cleared while the RHP panel is still animating closed. This prevents the withReportOrNotFound HOC from rendering "Not Found" inside the still-visible RHP on slower devices. This matches the existing pattern in RightModalNavigator.tsx:130-135 used for duplicate transaction reviews.

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

@MelvinBot move this out of draft

Done — PR has been moved out of draft and is now ready for review.

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

@MelvinBot please update the PR description to:

• Clearly explain all the changes made in this PR.
• Include permalinks to similar existing patterns in the codebase where we handle the same issue in other components (for example, MoneyReportHeader.tsx around lines 1539 and 1564).
• Mention that in this specific case, InteractionManager.runAfterInteractions is semantically the best fit — it is designed exactly to defer work until animations and interactions are complete.
• Clarify that the deprecation is only a TypeScript-level annotation from the React Native types. The API still works and is widely used, including elsewhere in this codebase.

Updated the PR description with:

• Clear explanation of both changes (deferred deleteTransaction in ReportDetailsPage.tsx + inverted focus condition fix in DeleteTransactionNavigateBackHandler.tsx)
• Permalinks to three existing patterns that use the same InteractionManager.runAfterInteractions approach for the same reason:
  • MoneyReportHeader.tsx:1539-1544
  • MoneyReportHeader.tsx:1563-1569
  • RightModalNavigator.tsx:130-135
• Note that InteractionManager.runAfterInteractions is semantically the best fit for deferring work until animations complete
• Clarification that the deprecation is TS-level only and the API is still functional and widely used in the codebase
• Added a "Slow device test" section with CPU throttling steps